-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement GOB (and avro) encoder and parser #240
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good, just some minor issues I've commented on. The biggest - beyond the test failures - is that config/https_gob_to_stdout.json and config/tester_to_https_gob.json needs to be moved. Configuration examples live in docs/examples and since these two are related, I suggest adding a new directory called docs/examples/avro/ and putting both in there instead, ideally a short README.rst explaining what they do - something short is fine, see for example docs/examples/kafka/README.rst for a short example.
Some background: Everything in config/ is the actual code responsbile for parsing and applying configuration files, not meant for storing actual configuration. Conversely, everything in docs/ is distributed when you install Skogul on a machine, and every configuration file in docs/examples/ will be automatically tested for validity (i.e.: testet if it parses, not actually run) on "make check".
…s to the readme file.
Deleted unwanted avro test data.json
fixes #227 and #228